From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Move tablespace path re-creation from the makefiles to pg_regres |
Date: | 2021-05-18 01:01:54 |
Message-ID: | YKMSAoSqh7Pvltus@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Mon, May 17, 2021 at 08:57:55PM -0400, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> One thing that's changing in this patch is that testtablespace would
>> be created even if the input directory does not exist when using
>> --make-testtablespace-dir.
>
> Yeah, I do not see a reason for there to be a connection. It's not
> pg_regress' job to decide whether the testtablespace directory is
> needed or not.
Fine by me. I don't think that's a big deal either way.
>> Worth noting that snprintf() is used twice instead of once to build
>> the tablespace path string.
>
> Yeah. I considered making a global variable so that there'd be
> just one instance of that, but didn't think it amounted to less
> mess in the end.
No problem from me here either.
>> The Windows part works correctly.
>
> Thanks for testing! I'll push this after the release is tagged.
Thanks!
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2021-05-18 19:17:55 | pgsql: doc: add PG 14 rel item about vacuum_cleanup_index_scale_factor |
Previous Message | Tom Lane | 2021-05-18 00:57:55 | Re: pgsql: Move tablespace path re-creation from the makefiles to pg_regres |
From | Date | Subject | |
---|---|---|---|
Next Message | Chapman Flack | 2021-05-18 01:19:00 | Re: allow specifying direct role membership in pg_hba.conf |
Previous Message | Kyotaro Horiguchi | 2021-05-18 00:58:05 | Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing. |