| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: fairywren hung in pg_basebackup tests |
| Date: | 2022-07-27 15:21:15 |
| Message-ID: | 3229f73c-50e6-69cc-6fc5-8905fde66a62@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-07-27 We 10:58, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> The alternative I thought of would be to switch msys to using our
>> dirent.c. Probably not too hard, but certainly more work than reverting.
> If you ask me, the shortest-path general-purpose fix is to insert
>
> #if MSYS
> if (pgwin32_is_junction(path))
> return PGFILETYPE_DIR;
> #endif
>
> at the start of get_dirent_type. (I'm not sure how to spell the
> #if test.) We could look at using dirent.c later, but I think
> right now it's important to un-break the buildfarm ASAP.
>
>
+1. I think you spell it:
#if defined(WIN32) && !defined(_MSC_VER)
(c.f. libpq-be.h)
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-07-27 15:43:19 | Re: [Commitfest 2022-07] Patch Triage: Waiting on Author |
| Previous Message | Robert Haas | 2022-07-27 15:20:46 | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |