Re: [Bug Fix] ECPG: could not use set xxx to default statement

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Higuchi, Daisuke" <higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [Bug Fix] ECPG: could not use set xxx to default statement
Date: 2019-02-19 04:27:15
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

"Higuchi, Daisuke" <higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com> writes:
> [ missing semicolon in gram.y breaks ecpg parsing of same construct ]

That's pretty nasty. The fix in gram.y is certainly needed, but I'm
unexcited by the regression test additions you propose. What I really
want to know is why a syntax error in gram.y wasn't detected by any
of the tools we use, and whether we can do something about that.
Otherwise the next bug of the same kind may go just as undetected;
in fact, I've got little confidence there aren't other such omissions
already :-(

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-02-19 04:35:34 Re: Prevent extension creation in temporary schemas
Previous Message Alvaro Herrera 2019-02-19 04:07:06 Re: Prepared transaction releasing locks before deregistering its GID