Re: Prepared transaction releasing locks before deregistering its GID

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Oleksii Kliukin <alexk(at)hintbits(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Prepared transaction releasing locks before deregistering its GID
Date: 2019-02-19 04:07:06
Message-ID: 20190219040706.GA17530@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Feb-19, Michael Paquier wrote:

> diff --git a/src/include/access/twophase.h b/src/include/access/twophase.h
> index 6228b091d8..2dcd08e9fa 100644
> --- a/src/include/access/twophase.h
> +++ b/src/include/access/twophase.h
> @@ -34,7 +34,7 @@ extern void TwoPhaseShmemInit(void);
> extern void AtAbort_Twophase(void);
> extern void PostPrepare_Twophase(void);
>
> -extern PGPROC *TwoPhaseGetDummyProc(TransactionId xid);
> +extern PGPROC *TwoPhaseGetDummyProc(TransactionId xid, bool lock_held);
> extern BackendId TwoPhaseGetDummyBackendId(TransactionId xid);
>
> extern GlobalTransaction MarkAsPreparing(TransactionId xid, const char *gid,

Hmm, ABI break ...

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-02-19 04:27:15 Re: [Bug Fix] ECPG: could not use set xxx to default statement
Previous Message Higuchi, Daisuke 2019-02-19 04:04:10 [Bug Fix] ECPG: could not use set xxx to default statement