Re: [Bug Fix] ECPG: could not use set xxx to default statement

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Higuchi, Daisuke" <higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: [Bug Fix] ECPG: could not use set xxx to default statement
Date: 2019-02-19 05:05:01
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I wrote:
> "Higuchi, Daisuke" <higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com> writes:
>> [ missing semicolon in gram.y breaks ecpg parsing of same construct ]

> That's pretty nasty. The fix in gram.y is certainly needed, but I'm
> unexcited by the regression test additions you propose. What I really
> want to know is why a syntax error in gram.y wasn't detected by any
> of the tools we use,

Ugh ... the Bison NEWS file has this:

* Changes in version 1.875, 2003-01-01:
- Semicolons are once again optional at the end of grammar rules.
This reverts to the behavior of Bison 1.33 and earlier, and improves
compatibility with Yacc.

I'd remembered how we had to run around and insert semicolons to satisfy
Bison 1.3-something, and supposed that that restriction still held.
But it doesn't. It seems though that our conversion script for creating
preproc.y depends on there being semicolons.

I think we need to fix that script to either cope with missing semicolons,
or at least complain about them. Too tired to look into how, right now.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-02-19 05:09:16 Re: Prevent extension creation in temporary schemas
Previous Message Michael Paquier 2019-02-19 05:02:24 Re: Offline enabling/disabling of data checksums