Re: implicit declaration of datumIsEqual in parse_coerce.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: implicit declaration of datumIsEqual in parse_coerce.c
Date: 2020-04-07 21:16:58
Message-ID: 27483.1586294218@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
> Not sure what changed, but I'm seeing this failure:

> parse_coerce.c: In function ‘coerce_type’:
> parse_coerce.c:345:9: warning: implicit declaration of function ‘datumIsEqual’ [-Wimplicit-function-declaration]
> 345 | if (!datumIsEqual(newcon->constvalue, val2, false, newcon->constlen))
> | ^~~~~~~~~~~~

That's inside "#ifdef RANDOMIZE_ALLOCATED_MEMORY", which probably
explains why most of us aren't seeing it. My guess is somebody
removed an #include without realizing that this chunk of code
needed it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-04-07 21:47:51 Re: proposal \gcsv
Previous Message Alexander Korotkov 2020-04-07 20:55:56 Re: [HACKERS] make async slave to wait for lsn to be replayed