implicit declaration of datumIsEqual in parse_coerce.c

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: implicit declaration of datumIsEqual in parse_coerce.c
Date: 2020-04-07 20:54:36
Message-ID: 20200407205436.pyjhddw5bn5upvsu@development
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Not sure what changed, but I'm seeing this failure:

parse_coerce.c: In function ‘coerce_type’:
parse_coerce.c:345:9: warning: implicit declaration of function ‘datumIsEqual’ [-Wimplicit-function-declaration]
345 | if (!datumIsEqual(newcon->constvalue, val2, false, newcon->constlen))
| ^~~~~~~~~~~~

Not sure if this because of compiler version (I'm on gcc 9.2.1) or
something else - I don't see any obvious changes to relevant parts of
the code, but I haven't dug too much.

Simply including 'utils/datum.h' resolves the issue.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2020-04-07 20:55:56 Re: [HACKERS] make async slave to wait for lsn to be replayed
Previous Message Justin Pryzby 2020-04-07 20:44:06 Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly