Re: Typo in pg_stat_activity definition

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Daisuke Higuchi <higuchi(dot)daisuke11(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Typo in pg_stat_activity definition
Date: 2025-06-30 04:54:39
Message-ID: 2731190.1751259279@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Jun 30, 2025 at 01:44:58PM +0900, Daisuke Higuchi wrote:
>> When I compared to the content before and after, I think the capital letter
>> "S" than "s" is suitable for alias, as shown below.

> Yeah, makes sense to me to fix this inconsistency on HEAD, even if
> it's benign.

Yeah, it's purely cosmetic. But +1 for consistency.

> One thing that you are forgetting is that the regression
> tests are going to fail: rules.out reports the definition of
> pg_stat_activity, and the characters casing matters in this case.

I doubt it --- the regression tests will show deparsing results,
which shouldn't change.

> Note that the new development cycle has officially begin, so that
> would touch only v19.

Since it's only cosmetic, I can't see much argument for back-patching.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-06-30 05:12:57 Re: Addition of %b/backend_type in log_line_prefix of TAP test logs
Previous Message Michael Paquier 2025-06-30 04:51:45 Re: Typo in pg_stat_activity definition