Re: Typo in pg_stat_activity definition

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daisuke Higuchi <higuchi(dot)daisuke11(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Typo in pg_stat_activity definition
Date: 2025-06-30 04:51:45
Message-ID: aGIX4WE13gma6n0F@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 30, 2025 at 01:44:58PM +0900, Daisuke Higuchi wrote:
> I noticed an inconsistency between uppercase and lowercase letters in only
> one place of pg_stat_activity definition, so I'll report it. I think this
> is just a typo and there is no functionality issue.
> When I compared to the content before and after, I think the capital letter
> "S" than "s" is suitable for alias, as shown below.

Yeah, makes sense to me to fix this inconsistency on HEAD, even if
it's benign. One thing that you are forgetting is that the regression
tests are going to fail: rules.out reports the definition of
pg_stat_activity, and the characters casing matters in this case.

Note that the new development cycle has officially begin, so that
would touch only v19.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-06-30 04:54:39 Re: Typo in pg_stat_activity definition
Previous Message Daisuke Higuchi 2025-06-30 04:44:58 Typo in pg_stat_activity definition