Re: Typo in pg_stat_activity definition

From: Daisuke Higuchi <higuchi(dot)daisuke11(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Typo in pg_stat_activity definition
Date: 2025-06-30 07:03:01
Message-ID: CAEVT6c_kbdSBu27pLW+KNCAAc185xpBHxRCXUPm-j01hq1Uw7g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you for comments!

>> One thing that you are forgetting is that the regression
>> tests are going to fail: rules.out reports the definition of
>> pg_stat_activity, and the characters casing matters in this case.
>
>I doubt it --- the regression tests will show deparsing results,
>which shouldn't change.

Yes, applying this patch will not cause the 'rules' test to fail.
Even if the pg_stat_activity view definition information in
system_views.sql is capitalized (inconsistency is fixed) by this patch, it
will be lowercase when this view is installed in database. So, the test
result does not change.

Just to be sure, I ran the 'make check' and 'make check-world', and I
confirmed that all tests were passed.

Regards.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2025-06-30 07:24:28 Re: Extend COPY FROM with HEADER <integer> to skip multiple lines
Previous Message shveta malik 2025-06-30 06:58:25 Re: Skipping schema changes in publication