| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, pryzby(at)telsasoft(dot)com, rjuju123(at)gmail(dot)com, daniel(at)manitou-mail(dot)org, AndrewBille(at)gmail(dot)com, michael(at)paquier(dot)xyz |
| Subject: | Re: ICU for global collation |
| Date: | 2022-09-16 07:56:31 |
| Message-ID: | 26461c69-cbce-c286-1716-41148b5e0f06@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 15.09.22 17:41, Marina Polyakova wrote:
> I agree with you. Here's another version of the patch. The
> locale/encoding checks and reports in initdb have been reordered,
> because now the encoding is set first and only then the ICU locale is
> checked.
I committed something based on the first version of your patch. This
reordering of the messages here was a little too much surgery for me at
this point. For instance, there are also messages in #ifdef WIN32 code
that would need to be reordered as well. I kept the overall structure
of the code the same and just inserted the additional proposed checks.
If you want to pursue the reordering of the checks and messages overall,
a patch for the master branch could be considered.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-09-16 07:57:39 | Re: ICU for global collation |
| Previous Message | John Naylor | 2022-09-16 07:54:14 | Re: [PoC] Improve dead tuple storage for lazy vacuum |