| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | peter(dot)eisentraut(at)enterprisedb(dot)com |
| Cc: | m(dot)polyakova(at)postgrespro(dot)ru, pgsql-hackers(at)postgresql(dot)org, pryzby(at)telsasoft(dot)com, rjuju123(at)gmail(dot)com, daniel(at)manitou-mail(dot)org, AndrewBille(at)gmail(dot)com, michael(at)paquier(dot)xyz |
| Subject: | Re: ICU for global collation |
| Date: | 2022-09-16 08:14:25 |
| Message-ID: | 20220916.171425.1790302207644891214.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Fri, 16 Sep 2022 09:56:31 +0200, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote in
> On 15.09.22 17:41, Marina Polyakova wrote:
> > I agree with you. Here's another version of the patch. The
> > locale/encoding checks and reports in initdb have been reordered,
> > because now the encoding is set first and only then the ICU locale is
> > checked.
>
> I committed something based on the first version of your patch. This
> reordering of the messages here was a little too much surgery for me
> at this point. For instance, there are also messages in #ifdef WIN32
> code that would need to be reordered as well. I kept the overall
> structure of the code the same and just inserted the additional
> proposed checks.
Yeah, as I sent just before, I reached the same conclusion.
> If you want to pursue the reordering of the checks and messages
> overall, a patch for the master branch could be considered.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-09-16 08:30:35 | Re: Make ON_ERROR_STOP stop on shell script failure |
| Previous Message | Kyotaro Horiguchi | 2022-09-16 08:11:16 | Re: ICU for global collation |