| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, pryzby(at)telsasoft(dot)com, rjuju123(at)gmail(dot)com, daniel(at)manitou-mail(dot)org, AndrewBille(at)gmail(dot)com, michael(at)paquier(dot)xyz |
| Subject: | Re: ICU for global collation |
| Date: | 2022-09-16 07:57:39 |
| Message-ID: | f1b3baa6-2bad-8be6-1458-3769f5c5989c@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16.09.22 09:31, Marina Polyakova wrote:
> IMO it is hardly understantable from the program output either - it
> looks like I manually chose the encoding UTF8. Maybe first inform about
> selected encoding?..
Yes, I included something like that in the patch just committed.
> diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
> index
> 6aeec8d426c52414b827686781c245291f27ed1f..348bbbeba0f5bc7ff601912bf883510d580b814c 100644
> --- a/src/bin/initdb/initdb.c
> +++ b/src/bin/initdb/initdb.c
> @@ -2310,7 +2310,11 @@ setup_locale_encoding(void)
> }
>
> if (!encoding && locale_provider == COLLPROVIDER_ICU)
> + {
> encodingid = PG_UTF8;
> + printf(_("The default database encoding has been set to \"%s\"
> for a better experience with the ICU provider.\n"),
> + pg_encoding_to_char(encodingid));
> + }
> else if (!encoding)
> {
> int ctype_enc;
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-09-16 08:11:16 | Re: ICU for global collation |
| Previous Message | Peter Eisentraut | 2022-09-16 07:56:31 | Re: ICU for global collation |