| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | QL Zhuo <zhuo(dot)dev(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Don't downcase filepath/filename while loading libraries |
| Date: | 2017-06-16 04:01:02 |
| Message-ID: | 26281.1497585662@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Fri, Jun 16, 2017 at 11:04 AM, QL Zhuo <zhuo(dot)dev(at)gmail(dot)com> wrote:
>> After few digging, I found there's a wrong use of `SplitIdentifierString` in
>> function `load_libraries` in /src/backend/utils/init/miscinit.c, and the
>> attached patch fixes it.
> That's a good catch. All the other callers of SplitIdentifierString()
> don't handle a list of directories. This requires a back-patch.
(1) As is, I think the patch leaks memory. SplitDirectoriesString's
API is not identical to SplitIdentifierString's.
(2) My inclination would be not to back-patch. This change could break
configurations that worked before, and the lack of prior complaints
says that not many people are having a problem with it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-06-16 04:18:01 | Re: PATCH: Don't downcase filepath/filename while loading libraries |
| Previous Message | Peter Eisentraut | 2017-06-16 03:40:52 | Re: Get stuck when dropping a subscription during synchronizing table |