Re: PATCH: Don't downcase filepath/filename while loading libraries

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: QL Zhuo <zhuo(dot)dev(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Don't downcase filepath/filename while loading libraries
Date: 2017-06-16 04:18:01
Message-ID: CAB7nPqQZOm6+oLRr_7ya5XbjrByGm1rjDp7+AZdr4s577xerow@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 16, 2017 at 1:01 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> (2) My inclination would be not to back-patch. This change could break
> configurations that worked before, and the lack of prior complaints
> says that not many people are having a problem with it.

That's fourteen years without complains, still I cannot imagine any
cases where it would be a problem as people who would have faced this
problem but not reported it have likely just enforced the FS to handle
case-insensitivity for paths. Or they just relied on the default: on
Windows the default is to be case-insensitive, as much as OSX. So the
proposed patch handles things better with case-sensitive paths,
without really impacting users with case-insensive FS.

I see the point of not back-patching the change though.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-06-16 04:27:33 Re: PATCH: Don't downcase filepath/filename while loading libraries
Previous Message Tom Lane 2017-06-16 04:01:02 Re: PATCH: Don't downcase filepath/filename while loading libraries