Re: PATCH: Don't downcase filepath/filename while loading libraries

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: QL Zhuo <zhuo(dot)dev(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Don't downcase filepath/filename while loading libraries
Date: 2017-06-16 02:34:34
Message-ID: CAB7nPqTSfvdE6v7d737H_eyxC6X5z6eZ3oQC65SyF+TDzy4Wxg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 16, 2017 at 11:04 AM, QL Zhuo <zhuo(dot)dev(at)gmail(dot)com> wrote:
> I just put this line in my postgresql.conf:
>
> ```
> shared_preload_libraries = '/Path/Contains/UpCaseWords/an_ext.so'
> ```
>
> Then the server couldn't start. It tried to load the file
> "/path/contains/upcasewords/an_ext.so" and failed.
>
> After few digging, I found there's a wrong use of `SplitIdentifierString` in
> function `load_libraries` in /src/backend/utils/init/miscinit.c, and the
> attached patch fixes it.

That's a good catch. All the other callers of SplitIdentifierString()
don't handle a list of directories. This requires a back-patch.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-06-16 03:38:08 Re: Something is rotten in publication drop
Previous Message Thomas Munro 2017-06-16 02:27:55 Re: Decimal64 and Decimal128