Re: --sync-method isn't documented to take an argument

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: --sync-method isn't documented to take an argument
Date: 2023-10-04 16:24:36
Message-ID: 2598486.1696436676@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Oct 4, 2023 at 11:27 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>> Here's a patch. I didn't address the class="parameter" stuff at all. I
>> figured it would be best to handle that separately.

> I guess I'll vote for including class=parameter in this addition for
> now, as that appears to be the majority position in the documentation
> today. If we get a consensus to change something, so be it. But also,
> if you don't want to do that, so be it.

FWIW, I just did a little sed hacking to count the instances of the
different cases in the docs as of today. I found

4038 <replaceable>
3 <replaceable class="command">
4017 <replaceable class="parameter">

The three with "command" are all in plpgsql.sgml, and are marking up
query strings in the synopses of EXECUTE and variants. I'm inclined
to argue that those three are actually wrong, on the grounds that

(1) From the perspective of EXECUTE, you could equally well say that
the string to be executed is a parameter;

(2) Our general convention elsewhere is that "command" refers to a
command type such as SELECT or UPDATE, not to a complete query string.

In any case, trying to standardize this looks like it would be a
huge amount of churn for very little gain. I'd recommend making
your markup look similar to what's immediately adjacent, if possible,
and not sweating too much otherwise.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2023-10-04 16:26:31 Re: Request for comment on setting binary format output per session
Previous Message Jim Jones 2023-10-04 16:19:18 Re: [PATCH] Add CANONICAL option to xmlserialize