| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Bernice Southey <bernice(dot)southey(at)gmail(dot)com> |
| Cc: | pgsql-general(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Indentation in a patch |
| Date: | 2025-11-25 18:58:25 |
| Message-ID: | 2595B96D-0A6E-472D-964A-8E87EC3B1C6B@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
> On 25 Nov 2025, at 19:14, Bernice Southey <bernice(dot)southey(at)gmail(dot)com> wrote:
> .. for my first ever patch attempt.
Awesome, we love to see new contributors!
> I'm tempted to submit my patch without indenting the
> if-block, and an explanation.
That's perfectly fine, an incorrectly indentend diff is fine to submit if it
makes it more readable (especially when coupled with a note explaining why).
> While I'm asking, I added a regression test and ran make check-world
> with the TAP tests. Anything else I should do before sending it to
> hackers?
Sounds like you've completed all the required steps.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rich Shepard | 2025-11-25 19:05:34 | Re: Selecting all variations of job title in a list |
| Previous Message | Bernice Southey | 2025-11-25 18:14:57 | Indentation in a patch |