| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Bernice Southey <bernice(dot)southey(at)gmail(dot)com> |
| Cc: | pgsql-general(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Indentation in a patch |
| Date: | 2025-11-26 11:05:00 |
| Message-ID: | cced0f25-8eb3-4af4-9c5f-6ea2a32cb351@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
On 25.11.25 19:58, Daniel Gustafsson wrote:
>> On 25 Nov 2025, at 19:14, Bernice Southey <bernice(dot)southey(at)gmail(dot)com> wrote:
>
>> .. for my first ever patch attempt.
>
> Awesome, we love to see new contributors!
>
>> I'm tempted to submit my patch without indenting the
>> if-block, and an explanation.
>
> That's perfectly fine, an incorrectly indentend diff is fine to submit if it
> makes it more readable (especially when coupled with a note explaining why).
Alternatively or additionally, git diff -w/--ignore-all-space can be
useful in situations like this.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | atma ram | 2025-11-26 13:20:41 | Question on PostgreSQL Table Partitioning – Performance of Queries That Do Not Use the Partition Key |
| Previous Message | immerrr again | 2025-11-26 10:38:48 | Re: DROP ROLE blocked by pg_init_privs |