Indentation in a patch

From: Bernice Southey <bernice(dot)southey(at)gmail(dot)com>
To: pgsql-general(at)lists(dot)postgresql(dot)org
Subject: Indentation in a patch
Date: 2025-11-25 18:14:57
Message-ID: CAEDh4nxfE_dte840rgD-YM8M57qijYGv-R75MLgPRx-+=pS6hQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-general

Hi,
I'm having a fight with git and indentation for my first ever patch
attempt. I'm just adding an if statement around an existing 70-line
code-block. It's a very simple few lines with --ignore-all-space. But
the patch file is noisy because of 140 lines of +/- indentation diffs.

I then realised the standard was tabs, and after fixing my spaces,
things got even worse. The 140 lines now interleave in many unreadable
chunks. I've tried different diff-algorithms, but they make no
difference. I'm tempted to submit my patch without indenting the
if-block, and an explanation. Any better suggestions?

While I'm asking, I added a regression test and ran make check-world
with the TAP tests. Anything else I should do before sending it to
hackers?

Thanks, Bernice

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Daniel Gustafsson 2025-11-25 18:58:25 Re: Indentation in a patch
Previous Message Adrian Klaver 2025-11-25 16:53:15 Re: Selecting all variations of job title in a list