Re: 'make check' fails

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 'make check' fails
Date: 2018-04-11 16:35:41
Message-ID: 25332.1523464541@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> Tom> Please be more explicit about what state you're starting from.

> This is consistently failing for me, on FreeBSD with GNU Make 4.2.1,
> clang 3.9.1, at commit 651cb90941:

> git clean -dfx
> ./configure '--prefix=/home/andrew/work/pgsql/head' \
> '--with-includes=/usr/local/include' '--with-libs=/usr/local/lib' \
> '--enable-debug' '--enable-depend' 'CFLAGS=-O0' '--enable-cassert' \
> gmake -j4
> gmake clean
> gmake -j4 check

Oh ... I forgot that "make clean" removes the symlinks in
src/include/catalog. Still, that also removes
src/include/utils/errcodes.h, so there was a parallel-make hazard
here before too.

We can fix this by making submake-generated-headers be a recursive
prerequisite for "check" as well as "all" and "install". I wonder
whether anybody is expecting any other shortcuts to work.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Teodor Sigaev 2018-04-11 16:39:20 Re: Partitioned tables and covering indexes
Previous Message Tom Lane 2018-04-11 16:25:50 Re: WARNING in parallel index creation.