Re: WARNING in parallel index creation.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WARNING in parallel index creation.
Date: 2018-04-11 16:25:50
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-03-12 20:44:01 -0700, Peter Geoghegan wrote:
>> I wonder why DefineCustomStringVariable() does not set var->reset_val.
>> We see that within DefineCustomEnumVariable(),
>> DefineCustomRealVariable(), DefineCustomIntVariable(), etc.

> Peter, have you investigated this any further? This has been an open
> item for a while.

It looks to me like the "oversight" in DefineCustomStringVariable is
not really one; rather, the reset_val assignments in the sibling
routines are dead code. define_custom_variable will call
InitializeOneGUCOption which overwrites reset_val from the boot_val
in all cases. We should probably clean this up by removing the dead

The WARNING seems to indicate that the error check in set_config_option
is too aggressive. I kind of wonder why it was placed there at all,
rather than in SQL-level operations like ExecSetVariableStmt.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-04-11 16:35:41 Re: 'make check' fails
Previous Message Andrew Gierth 2018-04-11 16:16:59 Re: 'make check' fails