Re: 'make check' fails

On Wed, Apr 11, 2018 at 12:35:41PM -0400, Tom Lane wrote:
> Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> > Tom> Please be more explicit about what state you're starting from.
>
> > This is consistently failing for me, on FreeBSD with GNU Make 4.2.1,
> > clang 3.9.1, at commit 651cb90941:
>
> > git clean -dfx
> > ./configure '--prefix=/home/andrew/work/pgsql/head' \
> > '--with-includes=/usr/local/include' '--with-libs=/usr/local/lib' \
> > '--enable-debug' '--enable-depend' 'CFLAGS=-O0' '--enable-cassert' \
> > gmake -j4
> > gmake clean
> > gmake -j4 check
>
> Oh ... I forgot that "make clean" removes the symlinks in
> src/include/catalog. Still, that also removes
> src/include/utils/errcodes.h, so there was a parallel-make hazard
> here before too.
>
> We can fix this by making submake-generated-headers be a recursive
> prerequisite for "check" as well as "all" and "install". I wonder
> whether anybody is expecting any other shortcuts to work.

In case it wasn't clear, I can reproduce this failure without parallel
mode. FYI, the reason I used this shortcut is so I can just run one
command and check one error code to know if they all worked; see
src/tools/pgtest for an example.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +