Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAP support

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAP support
Date: 2018-03-03 13:58:18
Message-ID: 2527ac24-68ed-7fdb-32bd-9daa36f21ec4@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/2/18 03:23, Michael Paquier wrote:
> That's a better idea. I have reworked that in 0001. What do you think?
> This has the same effect as diag(), which shows information directly to
> the screen, and that's the behavior I was looking for.

I ended up using plan skip_all, which seems to be intended for this
purpose, according to the documentation.

> I have concluded about using the most simple name: PG_TEST_EXTRA. A
> documentation attempt is added as well. This is unfortunately close to
> EXTRA_TESTS. It would be tempting to directly reuse EXTRA_TESTS as
> well, however this is used only for the core regression tests now, so a
> separated variable seems adapted to me.

Committed. Very nice.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-03-03 14:02:23 Re: [HACKERS] GSOC'17 project introduction: Parallel COPY execution with errors handling
Previous Message Amit Kapila 2018-03-03 13:44:55 Re: Contention preventing locking