| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAP support |
| Date: | 2018-03-03 22:37:24 |
| Message-ID: | 20180303223724.GB1378@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 03, 2018 at 08:58:18AM -0500, Peter Eisentraut wrote:
> On 3/2/18 03:23, Michael Paquier wrote:
>> That's a better idea. I have reworked that in 0001. What do you think?
>> This has the same effect as diag(), which shows information directly to
>> the screen, and that's the behavior I was looking for.
>
> I ended up using plan skip_all, which seems to be intended for this
> purpose, according to the documentation.
Yes, that's what I got as well first but...
>> I have concluded about using the most simple name: PG_TEST_EXTRA. A
>> documentation attempt is added as well. This is unfortunately close to
>> EXTRA_TESTS. It would be tempting to directly reuse EXTRA_TESTS as
>> well, however this is used only for the core regression tests now, so a
>> separated variable seems adapted to me.
>
> Committed. Very nice.
Thanks for the commit, Peter, PG_TEST_EXTRA is already set is my
environment.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-03-03 22:40:33 | Re: [HACKERS] PATCH: multivariate histograms and MCV lists |
| Previous Message | Tomas Vondra | 2018-03-03 22:18:15 | Re: autovacuum: change priority of the vacuumed tables |