Re: make update-po@master stops at pg_upgrade

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: make update-po@master stops at pg_upgrade
Date: 2022-07-13 19:35:15
Message-ID: 2463113.1657740915@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> On 13.07.22 20:19, Tom Lane wrote:
>> Hmm. We could list built files explicitly, perhaps, and still be
>> a good step ahead on the maintenance burden. Does xgettext get
>> upset if the same input file is mentioned twice, ie would we have
>> to filter sql_help.c out of the wildcard result?

> It seems it would be ok with that.

Actually, we can get rid of those easily enough anyway with $(sort).
Here's a draft that might solve these problems. The idea is to use
$(wildcard) for files in the srcdir, and manually enumerate only
built files.

regards, tom lane

Attachment Content-Type Size
use-wildcards-in-nls.mk-take-2.patch text/x-diff 16.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Malakhov 2022-07-13 19:45:40 Re: Pluggable toaster
Previous Message Zhihong Yu 2022-07-13 19:03:46 Re: Add SPLIT PARTITION/MERGE PARTITIONS commands