Re: make update-po@master stops at pg_upgrade

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: make update-po@master stops at pg_upgrade
Date: 2022-07-28 15:23:30
Message-ID: 20220728152330.xq5pck6et6cxuumk@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Jul-13, Tom Lane wrote:

> Actually, we can get rid of those easily enough anyway with $(sort).
> Here's a draft that might solve these problems. The idea is to use
> $(wildcard) for files in the srcdir, and manually enumerate only
> built files.

I checked the files in src/bin/scripts and they look OK; there are no
missing messages now. I also checked the es.po.new files with and
without patch; they look good, nothing is lost.

Files that weren't previously being processed:
src/interfaces/libpq/fe-print.c
src/interfaces/ecpg/preproc/parser.c

Incidentally, this patch is pretty similar to what Kyotaro-san sent when
opening the thread, with the addition of the $(notdir) call.

In short, +1 to this patch.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"El sentido de las cosas no viene de las cosas, sino de
las inteligencias que las aplican a sus problemas diarios
en busca del progreso." (Ernesto Hernández-Novich)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2022-07-28 15:29:44 Re: How come drongo didn't fail authentication here?
Previous Message Bharath Rupireddy 2022-07-28 14:55:47 Re: How to get accurate backup end time when it is taken from synchronous standby ?