Re: Recent cpluspluscheck failures

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Recent cpluspluscheck failures
Date: 2021-09-23 19:29:08
Message-ID: CAFBsxsGC2RL2Uj22_PsQYDgaJk6iLBQ9Q1s=p3REROjd20+g-A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 23, 2021 at 3:24 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
> > On Thu, Sep 23, 2021 at 2:37 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> On HEAD, I see these headers failing to compile standalone:
> >> $ src/tools/pginclude/cpluspluscheck
> >> In file included from /tmp/cpluspluscheck.XxTv1i/test.cpp:3:
> >> ./src/include/common/unicode_east_asian_fw_table.h:3:32: error:
elements
> > of array 'const mbinterval east_asian_fw []' have incomplete type
>
> > Okay, this file is used similarly to
> > src/include/common/unicode_combining_table.h, which has an exception in
the
> > check script, so I'll add another exception.
>
> OK, but see also src/tools/pginclude/headerscheck.
>
> regards, tom lane

Oh, I didn't know there was another one, will add it there also.

--
John Naylor
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-09-23 19:31:56 Re: Gather performance analysis
Previous Message Andrew Dunstan 2021-09-23 19:28:04 Re: very long record lines in expanded psql output