Re: pgsql: Move btbulkdelete's vacuum_delay_point()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Move btbulkdelete's vacuum_delay_point()
Date: 2006-02-14 22:13:23
Message-ID: 23277.1139955203@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> Perhaps if vacuum_delay_point() contained a timer check, we'd be able to
> see if any gap between vacuum delays was more than the actual delay
> itself. It would be nice to know they are all gone, forever.

vacuum_delay_point is intended to be cheap enough (in the non-delay
case) that no one would have any hesitation about dropping it into
loops. With a timer check in there, that might not be true, so I'm
resistant to doing it unconditionally. But I could see having some
#ifdef'd code that could be conditionally compiled in to measure the
maximum inter-delay-point time in a development build.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2006-02-14 22:51:32 Re: pgsql: Add psql option: -1 or --single-transaction
Previous Message Simon Riggs 2006-02-14 22:00:02 Re: pgsql: Move btbulkdelete's vacuum_delay_point()