Re: pgsql: Move btbulkdelete's vacuum_delay_point()

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Move btbulkdelete's vacuum_delay_point()
Date: 2006-02-14 22:00:02
Message-ID: 1139954402.1258.1027.camel@localhost.localdomain
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, 2006-02-14 at 15:55 -0500, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > On Tue, 2006-02-14 at 13:20 -0400, Tom Lane wrote:
> >> add missing vacuum_delay_point() call in btvacuumcleanup.
>
> > Cool and Interesting. That might explain some pretty dire performance
> > numbers from last week while running auto vacuum. Performance was
> > flat-lining for a while. Still need to investigate further though.
>
> Yeah, the missing delay would result in a spike in I/O demand from
> vacuum (auto or otherwise) while processing a big index, if you had
> vacuum delay configured. GIST had the same problem, too.

Perhaps if vacuum_delay_point() contained a timer check, we'd be able to
see if any gap between vacuum delays was more than the actual delay
itself. It would be nice to know they are all gone, forever.

Best Regards, Simon Riggs

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-02-14 22:13:23 Re: pgsql: Move btbulkdelete's vacuum_delay_point()
Previous Message Simon Riggs 2006-02-14 21:57:05 Re: pgsql: Add psql option: -1 or --single-transaction