| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add psql option: -1 or --single-transaction |
| Date: | 2006-02-14 22:51:32 |
| Message-ID: | 1139957492.1258.1038.camel@localhost.localdomain |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Tue, 2006-02-14 at 12:32 -0500, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > Just put an if test around that blob-handling behaviour. The code looks
> > very simple, so patch enclosed to augment the already-applied patch.
>
> Isn't the end-restore test backwards?
Corrected in enclosed patch. Another problem found and fixed also.
> > Chris, do you have a set-up to test out the blob behaviour?
>
> Just do a couple of lo_imports into a test database, dump, look at
> pg_restore's output to see if it's sane ...
Tests pass. BEGIN/COMMIT in correct places in log files (included).
Tests enclosed:
without single transaction
./test.sh > 0.log
with single transaction
./test.sh -1 > 1.log
Also tested with direct database connection, which works both in error
and success. [My earlier problem was a library version mismatch from the
recent update of the COPY protocol, thankfully.]
Best Regards, Simon Riggs
| Attachment | Content-Type | Size |
|---|---|---|
| lo_loader.sql | text/x-sql | 748 bytes |
| 0.log | text/x-log | 826 bytes |
| 1.log | text/x-log | 826 bytes |
| test.sh | application/x-shellscript | 483 bytes |
| 2withblobs.patch | text/x-patch | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User Agoldshuv | 2006-02-14 23:25:33 | bizgres - bizgres: Updated version number to 2.0.13 |
| Previous Message | Tom Lane | 2006-02-14 22:13:23 | Re: pgsql: Move btbulkdelete's vacuum_delay_point() |