Re: logical replication of truncate command with trigger causes Assert

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>
Subject: Re: logical replication of truncate command with trigger causes Assert
Date: 2021-06-12 18:43:08
Message-ID: 202106121843.c4uagunajhpm@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Jun-12, Tom Lane wrote:

> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> > On Fri, Jun 11, 2021 at 8:56 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> I was thinking maybe we could mark all these replication protocol
> >> violation errors non-translatable. While we don't want to crash on a
> >> protocol violation, it shouldn't really be a user-facing case either.
>
> > I don't see any problem with that as these are not directly related to
> > any user operation. So, +1 for making these non-translatable.
>
> Done that way.

Good call, thanks. Not only it's not very useful to translate such
messages, but it's also quite a burden because some of them are
difficult to translate.

--
Álvaro Herrera Valdivia, Chile
"Tiene valor aquel que admite que es un cobarde" (Fernandel)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2021-06-12 19:01:51 Avoid stuck of pbgench due to skipped transactions
Previous Message Justin Pryzby 2021-06-12 18:27:43 Re: A new function to wait for the backend exit after termination