Re: Cleanup isolation specs from unused steps

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Cleanup isolation specs from unused steps
Date: 2019-08-19 15:02:42
Message-ID: 23152.1566226962@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> I have been looking at the isolation tests, and we have in some specs
> steps which are defined but not used in any permutations.

Hmm, might any of those represent actual bugs? Or are they just
leftovers from test development?

> In order to
> detect them, I have been using the attached trick to track which
> permutations are used. This allows to find immediately any
> over-engineered spec by generating diffs about steps defined by not
> used in any permutations. On HEAD, we have six specs entering in this
> category.

Seems like a good idea; I'm surprised we've got so many cases.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Arne Roland 2019-08-19 15:17:21 Re: Partial join
Previous Message Daniel Westermann (DWE) 2019-08-19 14:45:51 Wrong sentence in the README?