| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: typedefs for indent |
| Date: | 2009-03-27 04:56:01 |
| Message-ID: | 2273.1238129761@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Frankly, I don't remember anyone complaining we didn't find any typedefs
> in pgindent,
There are lots and lots of places where it's obvious that pgindent
was misinformed on the subject, because it puts in a space where there
should not be one, eg "typename * ptr" instead of "typename *ptr".
Maybe I'm just being too anal in worrying about a space here or a space
there ... but then why do we run the thing at all?
This is the first time I've heard anyone suggest that false positives
could be a problem. What exactly would be the results of a false
match? Would it look worse than the false negatives do?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuhito Kasahara | 2009-03-27 06:44:51 | Re: display previous query string of idle-in-transaction |
| Previous Message | Tom Lane | 2009-03-27 04:28:56 | Re: 8.4 open items list |