orderRules() now a bad idea?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jan Wieck <JanWieck(at)Yahoo(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: orderRules() now a bad idea?
Date: 2002-10-14 19:13:08
Message-ID: 22454.1034622788@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I just noticed that rewriteHandler.c contains a subroutine orderRules()
that reorders the rules for a relation into the order
non-instead rules
qualified instead rules
unqualified instead rules
This conflicts with the feature we'd added to 7.3 to fire rules in
alphabetical order. (What will presently happen is they'll be fired
alphabetically in each of these categories.)

I see that the logic in fireRules() assumes that rules are processed in
this order, but that would be fairly easy to fix. Is there any other
good reason for doing this reordering? I'd like to remove orderRules()
and implement straight alphabetical ordering.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David De Graff 2002-10-14 19:42:37 Postgres-based system to run .org registry?
Previous Message Justin Clift 2002-10-14 19:07:46 Re: Anyone want to assist with the translation of the Advocacy