Re: orderRules() now a bad idea?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jan Wieck <JanWieck(at)Yahoo(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: orderRules() now a bad idea?
Date: 2002-10-14 22:53:27
Message-ID: 200210142253.g9EMrR129164@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> I just noticed that rewriteHandler.c contains a subroutine orderRules()
> that reorders the rules for a relation into the order
> non-instead rules
> qualified instead rules
> unqualified instead rules
> This conflicts with the feature we'd added to 7.3 to fire rules in
> alphabetical order. (What will presently happen is they'll be fired
> alphabetically in each of these categories.)
>
> I see that the logic in fireRules() assumes that rules are processed in
> this order, but that would be fairly easy to fix. Is there any other
> good reason for doing this reordering? I'd like to remove orderRules()
> and implement straight alphabetical ordering.

Unless Jan has an objection, I think alpha is best, because it matches
trigger rule odering. That original rule ordering isn't something
anyone is going to figure out on their own.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-10-14 23:00:15 Re: interesting side effect of autocommit = off
Previous Message Bruce Momjian 2002-10-14 22:41:27 Re: droped out precise time calculations in src/interfaces/libpq/fe-connect.c