Re: Arrays of Complex Types

David Fetter <david(at)fetter(dot)org> writes:
> 1. In src/backend/commands/tablecmds.c, change DefineRelation as
> follows:
> * After the first call to heap_create_with_catalog, construct and
> do another call to for the array type.

I'm still not happy about the idea of doing this for every relation
(and doing it for sequences and indexes would be the height of
wastefulness). How about we only do it for composite types?

> * Add an appropriate pg_depend entry.
> 2. Change RemoveRelation to reflect the above.

You only need one of those two: either you drop by hand or you let the
dependency machinery deal with it. Not both.

> Does the above make sense? Have I missed anything critical?

Ummm ... making it actually work? Possibly that just falls out, but I'm
not sure.

If it turns out that it does Just Work, you might take a stab at arrays
of domains too.

regards, tom lane