| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: headerscheck warnings with late-model gcc |
| Date: | 2025-08-29 14:47:39 |
| Message-ID: | 2159707.1756478859@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> On 07.08.25 16:58, Tom Lane wrote:
>> 0004: I prefer the solution I exhibited yesterday, ie add
>> externs to those headers.
> That solution seems fine, too.
Great.
> This comment should be clarified:
> + # This redundant extern declaration is needed to silence headerscheck
> + # warnings with some gcc versions.
> You could just write
> # silence -Wmissing-variable-declarations
> which also appears elsewhere in the code.
I compromised on writing "redundant declaration to silence
-Wmissing-variable-declarations", and pushed it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-08-29 14:57:08 | Re: [PATCH] Generate random dates/times in a specified range |
| Previous Message | Nathan Bossart | 2025-08-29 14:43:26 | Re: make LWLockCounter a global variable |