| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Boxuan Zhai <bxzhai2010(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "heikki(dot)linnakangas(at)enterprisedb(dot)com" <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Re: gSoC - ADD MERGE COMMAND - code patch submission |
| Date: | 2010-07-10 20:26:15 |
| Message-ID: | 20585.1278793575@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Fetter <david(at)fetter(dot)org> writes:
> On Sat, Jul 10, 2010 at 01:53:53PM -0400, Tom Lane wrote:
>> BTW, this patch is still a few bricks shy of a load, since there's
>> no kwlist.h change and so the new MERGE keyword couldn't possibly be
>> recognized. More generally, I'm wondering why the original .rar
>> submission was 300k (presumably compressed) and your diff is only
>> about 35k ...
> I'll look into that. From what you can see, is it worth trying to
> clean up, starting from base, or should we just wait for the next
> revision of the patch?
Well, rebasing against HEAD will presumably help the submitter
(assuming that he takes the advice to work against HEAD not 8.4.x).
But really what we need to see is design documentation, not code.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-07-10 20:29:08 | Re: [HACKERS] Re: pgsql: Add support for TCP keepalives on Windows, both for backend and |
| Previous Message | Bruce Momjian | 2010-07-10 20:23:17 | Re: pgsql: Add support for TCP keepalives on Windows, both for backend and |