| From: | David Fetter <david(at)fetter(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Boxuan Zhai <bxzhai2010(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "heikki(dot)linnakangas(at)enterprisedb(dot)com" <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Re: gSoC - ADD MERGE COMMAND - code patch submission |
| Date: | 2010-07-10 20:03:39 |
| Message-ID: | 20100710200339.GF5477@fetter.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 10, 2010 at 01:53:53PM -0400, Tom Lane wrote:
> David Fetter <david(at)fetter(dot)org> writes:
> > By the way, "make check" fails here with attached initdb.log:
>
> > creating system views ... FATAL: unrecognized token: "false"
>
> Hm, I'd suspect something fouled up in keyword recognition. Did you
> do a "make clean" and rebuild?
I did make maintainer-clean.
> BTW, this patch is still a few bricks shy of a load, since there's
> no kwlist.h change and so the new MERGE keyword couldn't possibly be
> recognized. More generally, I'm wondering why the original .rar
> submission was 300k (presumably compressed) and your diff is only
> about 35k ...
I'll look into that. From what you can see, is it worth trying to
clean up, starting from base, or should we just wait for the next
revision of the patch?
Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-07-10 20:17:05 | Re: ALTER TABLE SET STATISTICS requires AccessExclusiveLock |
| Previous Message | Peter Eisentraut | 2010-07-10 19:29:07 | Re: gSoC - ADD MERGE COMMAND - code patch submission |