| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add support for TCP keepalives on Windows, both for backend and |
| Date: | 2010-07-10 20:23:17 |
| Message-ID: | 201007102023.o6AKNHb09290@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander wrote:
> > An easy approximation would be to make the code #ifdef SIO_KEEPALIVE_VALS.
> > That would fail if the mingw guys decide to provide the #define without
> > adding the struct at the same time, but that seems moderately unlikely.
>
> Seems reasonable. I'll go do something along that line and verify that
> it actually works :-)
>
> That laves the questions of docs - right now the docs just say it
> works on windows. I guess we need to add some kind of disclaimer
> around that, but the fact is that for 99+% of our windows users it
> will work - since they use the binaries, and the binaries are built
> with the full api - so we shouldn't make it *too* prominent..
Wow, how would they know if the binaries are MinGW compiled? Does it
show in version()?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ None of us is going to be here forever. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-07-10 20:29:08 | Re: [HACKERS] Re: pgsql: Add support for TCP keepalives on Windows, both for backend and |
| Previous Message | Tom Lane | 2010-07-10 18:37:00 | pgsql: Add a note about preferred window width to the section about code |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-07-10 20:26:15 | Re: gSoC - ADD MERGE COMMAND - code patch submission |
| Previous Message | Bruce Momjian | 2010-07-10 20:17:05 | Re: ALTER TABLE SET STATISTICS requires AccessExclusiveLock |