Re: Row pattern recognition

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: assam258(at)gmail(dot)com, jian(dot)universality(at)gmail(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org, zsolt(dot)parragi(at)percona(dot)com, sjjang112233(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com
Subject: Re: Row pattern recognition
Date: 2026-07-11 05:53:43
Message-ID: 20260711.145343.660647222306289892.ishii@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Henson, Jian,

v50-0007-tidy-plumbing-more.patch
Looks good to me.

Minor points:

In nfa_advance_alt():

while (altIdx >= 0)
{
RPRPatternElement *altElem;
RPRNFAState *newState;

/* Branch jump/next links are always -1 or a valid index */
Assert(altIdx < pattern->numElements);

Since inside the while loop altIndx == -1 case is already excluded by
the while condition, the comment for the Assert is a little bit
strange. Probably following is better?

/* Branch jump/next links are always valid index */

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2026-07-11 06:04:56 Re: use of SPI by postgresImportForeignStatistics
Previous Message Tatsuo Ishii 2026-07-11 05:52:26 Re: Row pattern recognition