| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: use of SPI by postgresImportForeignStatistics |
| Date: | 2026-07-11 06:04:56 |
| Message-ID: | CAPmGK150WvOHo6Jrgmys-TpZ11ASj7vMRD5EfOKpaxRFuTYWuw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fujii-san,
On Fri, Jul 10, 2026 at 9:10 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Fri, Jul 10, 2026 at 8:37 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > My compiler (Apple clang version 17.0.0 (clang-1700.4.4.1)) doesn't
> > output any error/warning about that declaration. Actually, it's
> > allowed? Anyway, +1 for adding it for consistency.
>
> Maybe that's allowed. I wonder adding static to both the declaration
> and the definition seems mainly a matter of consistency, readability,
> and coding style.
>
> Thanks for the review! I've pushed the patch.
Thanks for working on this!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2026-07-11 07:15:58 | Re: sequencesync worker race with REFRESH SEQUENCES |
| Previous Message | Tatsuo Ishii | 2026-07-11 05:53:43 | Re: Row pattern recognition |