Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').
Date: 2026-06-17 00:34:22
Message-ID: CACJufxExrKM27norHzLfiHV1pmD8cuOfJXY5NFmO+F8GqpXFCQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 17, 2026 at 7:47 AM Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>

> > To fix this, ParseFuncOrColumn() now checks whether other than window
> > functions are used with the null treatment clause. If so, error out.
> >
> > Also remove the unnecessary test for "aggregate functions do not
> > accept RESPECT/IGNORE NULLS" because it is now checked in the
> > early-stage new check. The window regression test expected file is
> > changed accordingly.
>
> I'm going to push the patch today if there's no objection.

The code looks good to me, and the commit message is clear and well-written.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sergey Tatarintsev 2026-06-17 00:53:12 Re: 004_timeline_switch TAP test may fail
Previous Message Michael Paquier 2026-06-17 00:26:22 Re: faulty error handling around pgstat_count_io_op_time()