Re: Remove MSVC scripts from the tree

Hi,

On 2023-12-21 08:31:57 +0100, Peter Eisentraut wrote:
> On 20.12.23 18:22, Andrew Dunstan wrote:
> >
> > On 2023-12-20 We 11:32, Robert Haas wrote:
> > > On Wed, Dec 20, 2023 at 11:03 AM Andrew Dunstan
> > > <andrew(at)dunslane(dot)net> wrote:
> > > > > This could perhaps be related to this patch removing the module in
> > > > > src/tools/msvc/dummylib/Win32/Registry.pm ?
> > > > It is. I've fixed the buildfarm to stop checking this script.
> > > Thanks! But I wonder whether the script itself also needs to be
> > > changed? Are we expecting that the 'use Win32::Registry' in
> > > win32tzlist.pl would be satisfied externally in some case?
> > >
> >
> > Yes, the module will normally be present on a Windows perl. The only
> > reason we had dummylib was so we could check the perl scripts on Unix.
>
> But this use case still exists. Right now, running
>
> ./src/tools/perlcheck/pgperlsyncheck .
>
> fails because this module is missing. So I think we need to put the dummy
> module back somehow.

Can't we teach the tool that it should not validate src/tools/win32tzlist.pl
on !windows? It's obviously windows specific code, and it's special case
enough that there doesn't seem like a need to develop it on !windows.

Greetings,

Andres Freund