| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove MSVC scripts from the tree |
| Date: | 2023-12-21 07:31:57 |
| Message-ID: | a2bd77fd-61b8-4c2b-b12e-3e22ae260f82@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.12.23 18:22, Andrew Dunstan wrote:
>
> On 2023-12-20 We 11:32, Robert Haas wrote:
>> On Wed, Dec 20, 2023 at 11:03 AM Andrew Dunstan <andrew(at)dunslane(dot)net>
>> wrote:
>>>> This could perhaps be related to this patch removing the module in
>>>> src/tools/msvc/dummylib/Win32/Registry.pm ?
>>> It is. I've fixed the buildfarm to stop checking this script.
>> Thanks! But I wonder whether the script itself also needs to be
>> changed? Are we expecting that the 'use Win32::Registry' in
>> win32tzlist.pl would be satisfied externally in some case?
>>
>
> Yes, the module will normally be present on a Windows perl. The only
> reason we had dummylib was so we could check the perl scripts on Unix.
But this use case still exists. Right now, running
./src/tools/perlcheck/pgperlsyncheck .
fails because this module is missing. So I think we need to put the
dummy module back somehow.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-12-21 07:37:54 | Re: Remove MSVC scripts from the tree |
| Previous Message | Andrei Lepikhov | 2023-12-21 06:50:43 | Re: introduce dynamic shared memory registry |