Re: pgbench - adding pl/pgsql versions of tests

From: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
To: Cary Huang <cary(dot)huang(at)highgo(dot)ca>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Hannu Krosing <hannuk(at)google(dot)com>
Subject: Re: pgbench - adding pl/pgsql versions of tests
Date: 2023-06-05 08:05:26
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, 24 Mar 2023 22:17:33 +0000
Cary Huang <cary(dot)huang(at)highgo(dot)ca> wrote:

> The following review has been posted through the commitfest application:
> make installcheck-world: not tested
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: not tested

The patch would need documentations describing the new options.

> Hi
> thank you for the patch. It can be applied to current master branch and compiled fine.

I also confirmed that it can be applied and complied, although it raised warnings
about whitespace errors.

/tmp/pgbench-plpgsql-001.patch:68: trailing whitespace.
/tmp/pgbench-plpgsql-001.patch:102: trailing whitespace.
warning: 2 lines add whitespace errors.

> The feature works as described, I am able to run plpgsql-tpcb-like and plpgsql-simple-update scripts as you have added them.
> But I am not sure the purpose of --no-function to prevent the creation of pl/pgsql functions when the new plpgsql test scripts need them.
> I initialized pgbench database with --no-function, and plpgsql-tpcb-like and plpgsql-simple-update scripts will fail to run

I am not sure either whether --no-function option is necessary.
Although there is --no-vacuum, I guess this would be intended to
reduce the initialization time. I don't think omitting creating
functions has such effect. So, I wonder -no-function is unnecessary,
as similar to that there are no option to omitting to create tables.

Yugo Nagata

Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2023-06-05 08:15:39 Re: [PATCH] Slight improvement of worker_spi.c example
Previous Message benoit 2023-06-05 08:05:10 RE: Adding percentile metrics to pg_stat_statements module