Re: pgbench - adding pl/pgsql versions of tests

From: Cary Huang <cary(dot)huang(at)highgo(dot)ca>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Hannu Krosing <hannuk(at)google(dot)com>
Subject: Re: pgbench - adding pl/pgsql versions of tests
Date: 2023-03-24 22:17:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested


thank you for the patch. It can be applied to current master branch and compiled fine.

The feature works as described, I am able to run plpgsql-tpcb-like and plpgsql-simple-update scripts as you have added them.

But I am not sure the purpose of --no-function to prevent the creation of pl/pgsql functions when the new plpgsql test scripts need them.

I initialized pgbench database with --no-function, and plpgsql-tpcb-like and plpgsql-simple-update scripts will fail to run


Cary Huang
Highgo Software Canada

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Anton Kirilov 2023-03-24 22:38:48 Add PQsendSyncMessage() to libpq
Previous Message Jacob Champion 2023-03-24 21:47:40 Re: postgres_fdw, dblink, and CREATE SUBSCRIPTION security