Re: createuser --memeber and PG 16

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: createuser --memeber and PG 16
Date: 2023-05-21 19:16:58
Message-ID: 20230521191658.GA4052231@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 21, 2023 at 01:20:01PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> Fixed.
>
> v2 looks good to me, except the documentation wording for --with-role
> is needlessly inconsistent with --with-admin. The --with-admin
> wording looks better, so I suggest
>
> - Indicates the specified existing role should be automatically
> + Specifies an existing role that will be automatically
> added as a member of the new role. Multiple existing roles can

Will do.

>> How do folks feel about keeping --role undocumented? Should we give it a
>> mention in the docs for --member-of?
>
> I'm okay with leaving it undocumented, but I won't fight about it
> if somebody wants to argue for the other.

Alright. Barring any additional feedback, I'll commit this tonight.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-05-21 19:24:31 Re: PG 16 draft release notes ready
Previous Message Jonathan S. Katz 2023-05-21 19:04:58 Re: PG 16 draft release notes ready