From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: createuser --memeber and PG 16 |
Date: | 2023-05-22 00:11:18 |
Message-ID: | ZGqzJmHFEKxLLlk7@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, May 21, 2023 at 12:16:58PM -0700, Nathan Bossart wrote:
> On Sun, May 21, 2023 at 01:20:01PM -0400, Tom Lane wrote:
> > Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>>> How do folks feel about keeping --role undocumented? Should we give it a
>>> mention in the docs for --member-of?
>>
>> I'm okay with leaving it undocumented, but I won't fight about it
>> if somebody wants to argue for the other.
>
> Alright. Barring any additional feedback, I'll commit this tonight.
v2 passes the eye test, and I am not spotting any references to the
past option names. Thanks!
+$node->issues_sql_like(
+ [ 'createuser', 'regress_user11', '--role', 'regress_user1' ],
+ qr/statement: CREATE ROLE regress_user11 NOSUPERUSER NOCREATEDB NOCREATEROLE INHERIT LOGIN NOREPLICATION NOBYPASSRLS IN ROLE regress_user1;/,
+ '--role (for backward compatibility)');
Not sure I would have kept this test, still that's cheap enough to
test.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Anton Kirilov | 2023-05-22 00:18:09 | Re: Add PQsendSyncMessage() to libpq |
Previous Message | Jonathan S. Katz | 2023-05-21 23:53:38 | Re: PG 16 draft release notes ready |